shunping opened a new pull request, #40019:
URL: https://github.com/apache/beam/pull/40019

   ## Summary
   Moves Google Cloud Platform (GCP) secret manager implementations 
(`GcpSecret`, `GcpHsmGeneratedSecret`) and their `SecretRegistrar`s 
(`GcpSecretRegistrar`, `GcpHsmGeneratedSecretRegistrar`) out of 
`sdks/java/core` into `sdks/java/extensions/google-cloud-platform-core`.
   This decouples `beam-sdks-java-core` from GCP Secret Manager, Cloud KMS, and 
Tink dependencies, keeping `core` lightweight while still supporting dynamic 
secret registration when `google-cloud-platform-core` is on the classpath via 
`ServiceLoader`.
   
   Follow-up to https://github.com/apache/beam/pull/39940#discussion_r3907385124
   
   ## Changes
   - **Moved Source Classes**:
     - Moved `GcpSecret`, `GcpHsmGeneratedSecret`, `GcpSecretRegistrar`, and 
`GcpHsmGeneratedSecretRegistrar` from `org.apache.beam.sdk.util` 
(`sdks/java/core`) to `org.apache.beam.sdk.extensions.gcp.util` 
(`sdks/java/extensions/google-cloud-platform-core`).
     - Made `fromMap` and `resolveGcpProjectId` methods `public static` where 
needed.
   - **Migrated Tests**:
     - Extracted GCP secret unit tests from `SecretTest` into `GcpSecretTest` 
in `google-cloud-platform-core`.
     - Moved `GcpSecretRegistrarTest` to `google-cloud-platform-core`.
     - Extracted GCP KMS and Secret Manager tests for `GroupByKey` and 
`GroupByEncryptedKey` from `GroupByKeyTest` and `GroupByEncryptedKeyTest` into 
`GcpGroupByEncryptedKeyTest`.
     - Renamed and moved `GroupByKeyIT` from `sdks/java/core` to 
`GcpGroupByKeyIT` in `google-cloud-platform-core`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to