tianz101 commented on code in PR #37991:
URL: https://github.com/apache/beam/pull/37991#discussion_r3938189814
##########
.github/workflows/beam_PreCommit_Go.yml:
##########
@@ -85,8 +85,6 @@ jobs:
with:
java-version: default
go-version: default
- - name: Install Cloud Spanner emulator
Review Comment:
why the have to be removed?
##########
sdks/go/pkg/beam/io/spannerio/CHANGESTREAM.md:
##########
@@ -0,0 +1,260 @@
+<!--
Review Comment:
A spanner change stream can be created with
partition_mode='IMMUTABLE_KEY_RANGE' vs partition_mode = 'MUTABLE_KEY_RANGE'.
What you are doing here only work for a change stream
of IMMUTABLE_KEY_RANGE (default) where ChildParititonRecord is returned.
This is a heads up for
1) document your connector restriction and 2) structure things so later you
can expand to MUTABLE_KEY_RANGE mode easily. Thanks. You can look the java sdk
readChangeStream function to
get some ideas on how both modes are supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
