Eliaaazzz commented on PR #39916:
URL: https://github.com/apache/beam/pull/39916#issuecomment-5549466369
> PTAL @Eliaaazzz thanks!
Thanks Yi, LGTM! The WINDOWS_INVALID_CHARS splitter is a nicer resolution
than my allowlist suggestion — it fixes base while keeping non-ASCII filenames
intact.
Verified daebfe499 locally on macOS (JDK 17):
:runners:java-fn-execution:test passes, 365 tests / 34 classes, including
testStageFileArtifactWithAbsolutePath. Also checked the splitter against
Windows/POSIX absolute paths, Unicode names, and degenerate inputs (/, "",
trailing separators) — all produce sane basenames, with orElse("artifact")
covering the all-separator case.
One side benefit worth noting: since base is now flattened on all OSes, file
artifacts with absolute paths no longer create nested directories under the
staging dir on Linux — which removeStagedArtifacts' top-level glob never
cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
