aIbrahiim commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3943444213
##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
# errors raised during async flushes instead of swallowing them.
'google-cloud-bigtable>=2.42.0,<3',
'google-cloud-build>=3.35.0,<4',
+ 'google-cloud-firestore>=2.0.0,<3',
Review Comment:
I tried moving it to the test extra and made the import optional in
integration_tests.py
but with it in test, plain [test] tox envs pull in google-cloud-core
without google.cloud.storage and GCS / BigQuery dataframe tests start failing
(ModuleNotFoundError: google.cloud.storage, etc.)
so I kept the optional import, but left the package under gcp next to the
other GCP test clients (bigtable/spanner), or do you suggest another splitting
approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
