chadrik commented on a change in pull request #13004:
URL: https://github.com/apache/beam/pull/13004#discussion_r499846388
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -164,14 +168,19 @@ def merge(self, merge_context):
raise NotImplementedError
def is_merging(self):
+ # type: () -> bool
+
"""Returns whether this WindowFn merges windows."""
return True
@abc.abstractmethod
def get_window_coder(self):
+ # type: () -> coders.Coder
Review comment:
`coder.Coder` is not yet `Generic`, so we can't do that just yet, though
we can do this in a future PR. So this should not be one of the `*WindowCoder`
types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
