scwhittle commented on code in PR #40209:
URL: https://github.com/apache/beam/pull/40209#discussion_r4075126763
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -325,6 +326,12 @@ public ProcessContinuation run(
watermarkEstimator));
return maybeContinuation.get();
}
+
+ if (record.getRecordTimestamp() != null
Review Comment:
I don't think you need changes in the the loop here, as each of the action
types tries to claim the appropriate timestamp before processing (part of the
splittable-dofn model is it must attempt to claim first and then respect
whether or not that claim fails).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
