kennknowles commented on code in PR #40109:
URL: https://github.com/apache/beam/pull/40109#discussion_r4083923596
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/io/FileSystemsTest.java:
##########
@@ -63,6 +63,38 @@ public class FileSystemsTest {
@Rule public ExpectedException thrown = ExpectedException.none();
private LocalFileSystem localFileSystem = new LocalFileSystem();
+ @Test
+ public void testMatchSingleFileSpecExceptionChaining() throws Exception {
+ java.io.IOException rootCause = new java.io.IOException("403 Forbidden:
Fake GCS Error");
+ MatchResult failedResult = MatchResult.create(MatchResult.Status.ERROR,
rootCause);
+
+ FileSystem mockFileSystem = mock(FileSystem.class);
Review Comment:
Actually yes I would prefer that. A private fake of our own will be less
vulnerable to arbitrary behavior than mockito, and it would probably be pretty
easy to make it have enough "real" functionality to be useful across different
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
