nitinware opened a new pull request, #40317:
URL: https://github.com/apache/beam/pull/40317
addresses #20501 (subtask of umbrella #20497)
Removes blanket `nullness` suppressions from the `:sdks:java:extensions:sql`
module.
- **ParquetTable** — drop the class-level `@SuppressWarnings({"nullness"})`;
guard the nullable `table.getLocation()` at its three call sites with
`checkArgumentNotNull`. A Parquet table always has a location, and the prior
code already dereferenced it (`resolveFilePattern` calls
`location.endsWith(...)`), so this only turns a would-be NPE into a clearer
`IllegalArgumentException`.
- **TestTableUtils** — drop the stale `nullness` key; keep `keyfor` (tracked
separately under #20447).
- **BeamSqlEnv** — keep one narrow, documented single-statement
`@SuppressWarnings("nullness")` on `Field.get(null)`: the checker's annotated
JDK stub marks the receiver `@NonNull`, so removing it is a real error, not a
spurious one.
Verified locally: `:sdks:java:extensions:sql:compileJava --rerun-tasks` is
clean under the nullness checker, and the full `:sdks:java:extensions:sql:test`
suite passes (793 passed, 8 pre-existing skips, 0 failures).
R: @kennknowles
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [X] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
