claudevdm commented on code in PR #40252:
URL: https://github.com/apache/beam/pull/40252#discussion_r4126876494
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFiles.java:
##########
@@ -1218,7 +1308,18 @@ public static Metrics getFileMetrics(
if (!ParquetSchemaUtil.hasIds(originalMessageType)) {
footer = getFooterWithTypeIds(originalMessageType, footer, mapping);
}
Review Comment:
Same fix as comment #3: getFileMetrics now takes the checked footer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
