damccorm commented on code in PR #40315: URL: https://github.com/apache/beam/pull/40315#discussion_r4134308418
########## .github/REVIEWERS.yml: ########## @@ -17,14 +17,18 @@ # add yourself to that label's exclusionList # FallbackReviewers is for reviewers who can review any area of the code base that might # not receive a label. These should generally be more experienced committers. +# Priority determines which label is used to select a reviewer when a PR has multiple labels +# (lower number = higher priority). Review Comment: @kennknowles @Abacn I'd appreciate your thoughts on this approach since you've both been thinking about things in this space. The core idea here is to use priority to pick a single reviewer from the available set using priority to pick the best label (with ties being broken randomly). Not asking for a full review yet (I'm not confident in code quality elsewhere yet anyways), but I'm specifically looking for feedback on: 1. The overall approach 2. The priorities I've defined in this file. https://github.com/apache/beam/pull/40315#issuecomment-5891600338 has analysis on what the outcome of this PR would be, and I think it is promising. Noting that I'm still interested in https://github.com/apache/beam/pull/39980 as the ultimate answer here, but that is harder (both from an infra perspective and in terms of meeting some of the other goals like fairness). This could be a step forward while we wait on that. If we think this is a good idea, I'll eventually take it to the dev list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
