kennknowles commented on code in PR #40322:
URL: https://github.com/apache/beam/pull/40322#discussion_r4134672134
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/metrics/MetricsTest.java:
##########
@@ -101,77 +105,88 @@ public void tearDown() {
}
protected PipelineResult runPipelineWithMetrics() {
- final Counter count = Metrics.counter(MetricsTest.class, "count");
- StringSet sideinputs = Metrics.stringSet(MetricsTest.class,
"sideinputs");
- final TupleTag<Integer> output1 = new TupleTag<Integer>() {};
- final TupleTag<Integer> output2 = new TupleTag<Integer>() {};
- pipeline
- .apply(Create.of(5, 8, 13))
- .apply(
- "MyStep1",
- ParDo.of(
- new DoFn<Integer, Integer>() {
- Distribution bundleDist =
Metrics.distribution(MetricsTest.class, "bundle");
-
- @StartBundle
- public void startBundle() {
- bundleDist.update(10L);
- }
-
- @SuppressWarnings("unused")
- @ProcessElement
- public void processElement(ProcessContext c) {
- Distribution values =
Metrics.distribution(MetricsTest.class, "input");
- StringSet sources = Metrics.stringSet(MetricsTest.class,
"sources");
- BoundedTrie boundedTrieSources =
- Metrics.boundedTrie(MetricsTest.class,
"boundedTrieSources");
- count.inc();
- values.update(c.element());
-
- c.output(c.element());
- c.output(c.element());
- sources.add("gcs");
- sources.add("gcs"); // repeated should appear once
- sources.add("gcs", "gcs"); // repeated should appear once
- sideinputs.add("bigtable", "spanner");
- boundedTrieSources.add(ImmutableList.of("ab_source",
"cd_source"));
- boundedTrieSources.add(ImmutableList.of("ef_source"));
- }
-
- @DoFn.FinishBundle
- public void finishBundle() {
- bundleDist.update(40L);
- }
- }))
- .apply(
- "MyStep2",
- ParDo.of(
- new DoFn<Integer, Integer>() {
- @SuppressWarnings("unused")
- @ProcessElement
- public void processElement(ProcessContext c) {
- Distribution values =
Metrics.distribution(MetricsTest.class, "input");
- Gauge gauge = Metrics.gauge(MetricsTest.class,
"my-gauge");
- StringSet sinks =
Metrics.stringSet(MetricsTest.class, "sinks");
- BoundedTrie boundedTrieSinks =
- Metrics.boundedTrie(MetricsTest.class,
"boundedTrieSinks");
- Integer element = c.element();
- count.inc();
- values.update(element);
- gauge.set(12L);
- c.output(element);
- sinks.add("bq", "kafka", "kafka"); // repeated
should appear once
- sideinputs.add("bigtable", "sql");
- boundedTrieSinks.add(ImmutableList.of("ab_sink",
"cd_sink"));
- boundedTrieSinks.add(ImmutableList.of("ef_sink"));
- c.output(output2, element);
- }
- })
- .withOutputTags(output1, TupleTagList.of(output2)));
- PipelineResult result = pipeline.run();
-
- result.waitUntilFinish();
- return result;
+ String cacheKey =
+ pipeline.getOptions().getRunner().getName()
Review Comment:
I don't have a lot of context, but I do have concerns.
1. There is nothing in the cache key to identify the pipeline. Is there just
one pipeline possible here? Reading this file, I guess so? The tests are really
poor, with mysterious action-at-a-distance between magic values in the
`runPipelineWithMetrics` helper and the `assertGauges` and so on. I know you
aren't here to fix this...
2. This is a `protected` method so presumably used in test suites that
extend this one? Frankly this is an anti-pattern that we should have a coding
agent eliminate, in favor of simple control flow by calling helper methods. And
of course if someone overrides the protected method, they lose the caching
_and_ the coherence between the test methods and the run pipeline method.
Honestly, having an agent fully rewrite this file might be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
