claudevdm commented on code in PR #40225: URL: https://github.com/apache/beam/pull/40225#discussion_r4170159101
########## sdks/python/apache_beam/io/gcp/bigquery.py: ########## @@ -29,7 +29,10 @@ Also, for programming convenience, instances of TableReference and TableSchema have a string representation that can be used for the corresponding arguments: - - TableReference can be a PROJECT:DATASET.TABLE or DATASET.TABLE string. + - TableReference can be a PROJECT:DATASET.TABLE, PROJECT.DATASET.TABLE or + DATASET.TABLE string. Lakehouse runtime catalog (BigLake metastore) tables Review Comment: I dont see a way we can force a standard format. `table` is just a string, so we only find out whether it's a 3-part or 4-part reference by parsing it. We also can't drop the colon form. `get_hashable_destination` converts a `TableReference` into `PROJECT:DATASET.TABLE` as the canonical string representation. So we need colon because of `get_hashable_destination`, and dot because it's the modern SQL form we want to encourage. Deprecating colon would be nice, but it's the destination key throughout the write path, so that's a bigger breaking change. Updated the docs to mention that project is required for pcnt format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
