aIbrahiim commented on PR #40370: URL: https://github.com/apache/beam/pull/40370#issuecomment-6014028091
> There are multiple changes here that need to be made separately IMO > > * changing the `leader_board.py` to set allowed lateness (I don't believe changing the trigger matters) > * improving plumbing for a clock in trigger execution (this does look useful and good!) > > I believe just using allowed lateness with existing trigger should have the same impact on the integration test, FWIW. But I do think your other changes looks useful. I split the clock change out of this PR. The FnApi clock plumbing is in a separate PR #40429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
