damccorm commented on code in PR #40359: URL: https://github.com/apache/beam/pull/40359#discussion_r4251709791
########## sdks/python/apache_beam/io/gcp/bigquery_compat.py: ########## @@ -15,1440 +15,152 @@ # limitations under the License. # -"""Compatibility shims and legacy client emulation for BigQuery. +"""Bridge for legacy apitools BigQuery message inputs. Review Comment: I'm having a hard time orienting myself in this PR. Could you help me with a few things before I fully jump in: 1) Could you give an overarching summary of what the PR is trying to accomplish? Is the idea basically that instead of emulating the old client, we convert the type to just use the new client (isn't this still basically emulating the client?)? 2) Any recommendations on how to review this? Or are there ways to split it up? Should I review this file as a diff or just a replacement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
