github-actions[bot] commented on code in PR #40593:
URL: https://github.com/apache/beam/pull/40593#discussion_r4275999072
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BoundedQueueExecutor.java:
##########
@@ -185,6 +200,18 @@ public boolean executorQueueIsEmpty() {
return executor.getQueue().isEmpty();
Review Comment:
**🟢 Low**: With lazy removal of stolen work, `workQueue` may still contain
stale `QueuedWork` shells (e.g., if work was stolen and all worker threads are
currently blocked inside long-running bundles without dequeuing, and
`workQueue.size()` hasn't crossed `purgeQueueSizeThreshold`). As a result,
`executorQueueIsEmpty()`—which is used by
`StreamingDataflowWorker.executorQueueIsEmpty()` and `WorkerCustomSources` to
decide whether to split backlog—can return `false` even when no runnable work
remains in the queue. Consider purging stale shells or checking for unclaimed
entries if `workQueue` is non-empty here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
