jrmccluskey commented on code in PR #40578: URL: https://github.com/apache/beam/pull/40578#discussion_r4283652970
########## sdks/python/apache_beam/typehints/opcodes.py: ########## @@ -506,6 +523,13 @@ def load_small_int(state, arg): state.stack.append(Const(arg)) +def load_common_constant(state, arg): Review Comment: It doesn't have a direct call but will be used when the typehint tests run on 3.15. The functions defined in opcodes.py get imported in [infer_return_type_func()](https://github.com/apache/beam/blob/1a017df4529bc6b005eaa2a4d12ddb63fa2569f5/sdks/python/apache_beam/typehints/trivial_inference.py#L364) and placed into a dictionary, then [invoked through that dict entry](https://github.com/apache/beam/blob/1a017df4529bc6b005eaa2a4d12ddb63fa2569f5/sdks/python/apache_beam/typehints/trivial_inference.py#L631) rather than calling the function directly. This is the general convention for any operation that doesn't do more complex behavior like modifying the program counter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
