damccorm commented on code in PR #40558:
URL: https://github.com/apache/beam/pull/40558#discussion_r4283870400
##########
sdks/python/apache_beam/utils/secret.py:
##########
@@ -110,22 +128,35 @@ def parse_secret_option(cls, secret: str) -> 'Secret':
if not secret_manager:
raise ValueError(
f'Invalid secret type {secret_type}, currently only '
- 'GcpSecret and GcpHsmGeneratedSecret are supported')
+ 'GcpSecret, GcpHsmGeneratedSecret, and AwsSecret are supported')
Review Comment:
Minor: Could we autogenerate this list so that we don't need to keep it in
sync?
##########
sdks/python/apache_beam/utils/secret.py:
##########
@@ -163,7 +194,7 @@ def from_json(
return secret_cls(spec)
else:
raise ValueError(
- f"Unsupported secret manager: '{secret_manager_name}'. Currently
supported options: 'GoogleCloudSecretManager',
'GoogleCloudHsmGeneratedSecretManager'."
+ f"Unsupported secret manager: '{secret_manager_name}'. Currently
supported options: 'GoogleCloudSecretManager',
'GoogleCloudHsmGeneratedSecretManager', 'AwsSecretsManager'."
Review Comment:
Same as above, can we autogenerate this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
