shunping commented on code in PR #40571: URL: https://github.com/apache/beam/pull/40571#discussion_r4284613823
########## sdks/python/apache_beam/dataframe/frames.py: ########## @@ -1589,7 +1589,9 @@ def dot(self, other): @frame_base.with_docs_from(pd.Series) @frame_base.args_to_kwargs(pd.Series) @frame_base.populate_defaults(pd.Series) - def nunique(self, **kwargs): + def nunique(self, dropna, **kwargs): Review Comment: Looks like we changed the api signature here. Is it going to cause a compatibility issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
