lostluck commented on a change in pull request #13028:
URL: https://github.com/apache/beam/pull/13028#discussion_r501397913
##########
File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go
##########
@@ -204,60 +218,89 @@ func (m *marshaller) addScopeTree(s *ScopeTree) string {
EnvironmentId: m.addDefaultEnv(),
}
- m.updateIfCombineComposite(s, transform)
+ if err := m.updateIfCombineComposite(s, transform); err != nil {
+ return "", errors.Wrapf(err, "failed to add socpe tree: %v", s)
Review comment:
Typo I missed on the first pass.
```suggestion
return "", errors.Wrapf(err, "failed to add scope tree: %v", s)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
