reuvenlax commented on PR #39619: URL: https://github.com/apache/beam/pull/39619#issuecomment-6281985224
We probably don't want to fully flatten for huge schemas, but we can easily skip the unrolling if the schema has > N fields. On Tue, Oct 13, 2026 at 6:51 AM Kenn Knowles ***@***.***> wrote: > *kennknowles* left a comment (apache/beam#39619) > <https://github.com/apache/beam/pull/39619#issuecomment-6147100103> > > Spending a lot of time up front in order to make flattened straight-line, > unrolled coders, is almost certainly the right direction. > > Given today's tech: > > - I think we could pretty reasonably get fully flattened and > concreteized generated coders (these were always possible, but hard to > implement and hard to get right, before) > - Test the generator against exact input/output matching of arbitrary > "slow version" reflective coders. > - Run the above test as a fuzz test of arbitrary generated schemas. > > If we can pass a few seconds of fuzz testing of arbitrary schemas, the > chance that there's a weird one hiding is very low. We could also do > exhaustive testing up to some depth (in other words move from 'quickcheck' > model to 'smallcheck' model) and this would give a ton of assurance. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/39619?email_source=notifications&email_token=AFAYJVPPOWJDOUNT2YPSJST5TYXOPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJUG4YTAMBRGAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6147100103>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAYJVKARLMRVUQPOQFCFPT5TYXOPAVCNFSNUABEKJSXA33TNF2G64TZHM2TAOJQGQZDINJ3JFZXG5LFHM2TANRVGEYTGMZXGKQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AFAYJVMNOSLQX6R2IKZLTF35TYXOPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJUG4YTAMBRGAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AFAYJVPPRAW4EGFECMOQUYL5TYXOPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMJUG4YTAMBRGAZ2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
