claudevdm commented on code in PR #40675:
URL: https://github.com/apache/beam/pull/40675#discussion_r4338297528
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1044,6 +1044,15 @@ def _add_argparse_args(cls, parser):
'resolved by the Google Cloud client library, which honors '
'GOOGLE_CLOUD_UNIVERSE_DOMAIN and otherwise uses the default '
'public URL (%s).' % cls.DATAFLOW_ENDPOINT))
+ parser.add_argument(
+ '--bigquery_endpoint',
Review Comment:
Can we add a BigQueryOptions override of pipelineoptions instead of adding
this to GoogleCloudOptions?
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1044,6 +1044,15 @@ def _add_argparse_args(cls, parser):
'resolved by the Google Cloud client library, which honors '
'GOOGLE_CLOUD_UNIVERSE_DOMAIN and otherwise uses the default '
'public URL (%s).' % cls.DATAFLOW_ENDPOINT))
+ parser.add_argument(
+ '--bigquery_endpoint',
Review Comment:
Is this meant to apply to xlang BQ too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
