shunping commented on code in PR #40672:
URL: https://github.com/apache/beam/pull/40672#discussion_r4342701708
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java:
##########
@@ -47,15 +48,22 @@ public interface DataflowPipelineDebugOptions
* The root URL for the Dataflow API. {@code dataflowEndpoint} can override
this value if it
* contains an absolute URL, otherwise {@code apiRootUrl} will be combined
with {@code
* dataflowEndpoint} to generate the full URL to communicate with the
Dataflow API.
+ *
+ * <p>If not set, the root URL is resolved by the Google API client library,
which honors {@code
+ * GOOGLE_CLOUD_UNIVERSE_DOMAIN} and otherwise uses the default public URL
({@value
+ * Dataflow#DEFAULT_ROOT_URL}).
*/
@Description(
"The root URL for the Dataflow API. dataflowEndpoint can override this "
+ "value if it contains an absolute URL, otherwise apiRootUrl will
be combined with "
- + "dataflowEndpoint to generate the full URL to communicate with the
Dataflow API.")
- @Default.String(Dataflow.DEFAULT_ROOT_URL)
- String getApiRootUrl();
+ + "dataflowEndpoint to generate the full URL to communicate with the
Dataflow API. "
+ + "If not set, the root URL is resolved by the Google API client
library, which "
+ + "honors GOOGLE_CLOUD_UNIVERSE_DOMAIN and otherwise uses the
default public URL ("
+ + Dataflow.DEFAULT_ROOT_URL
+ + ").")
+ @Nullable String getApiRootUrl();
- void setApiRootUrl(String value);
+ void setApiRootUrl(@Nullable String value);
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
