tvalentyn commented on code in PR #40714:
URL: https://github.com/apache/beam/pull/40714#discussion_r4343073778
##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -2078,10 +2078,12 @@ def __init__(
self,
models: Union[list[Any], ModelManager],
model_tag: str,
- loader_func: Optional[Callable[[], Any]] = None):
+ loader_func: Optional[Callable[[], Any]] = None,
+ metric_tag: Optional[str] = None):
self.models = models
self.use_model_manager = not isinstance(models, list)
self.model_tag = model_tag
+ self.metric_tag = metric_tag or model_tag
Review Comment:
could we clarify in the docstring the difference between these two concepts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
