damccorm commented on PR #40717: URL: https://github.com/apache/beam/pull/40717#issuecomment-6364039910
> > Haven't done a thorough review, but could you help me understand the goal here? > > GitHub already renders the diff size directly above the labels, so I'm not sure how much info this adds > > Other Github repos have this feature and when looking through the PRs from the main PR page you can quickly tell what size the PRs are and maybe review those first without clicking on PR to determine how large the changes are. > > Its a small workflow with little maintenance, but with added benefit. Thanks I'm fine adding this, particularly now that we've reafactored to use an external action. But the underlying principle I want us to be careful of is adding code that has limited value since [code is a liability](https://somehowmanage.com/2020/10/17/code-is-a-liability-not-an-asset/). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
