sjvanrossum commented on PR #40606: URL: https://github.com/apache/beam/pull/40606#issuecomment-6405999495
> One change causes it: `DEFAULT_MAX_MESSAGES_BEFORE_CHECK` I overlooked the easiest thing! Yeah, that looks a lot better now. The current implementation varies quite a bit on my laptop, whereas both #40606 and #40788 (patched now) tighten that up quite a bit and are nearly identical (at least on a MacBook Pro with M5 Pro). I'll run this benchmark on a few different machine types for an extended period of time when I'm at the office tomorrow. Benchmark | testLargeBundle -- | -- master | 13,070.3 ± 1,020.6 #40606 | 13,837.3 ± 559.3 (+5.9%) #40788 | 14,361.8 ± 308.5 (+9.9%) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
