mananmangal commented on code in PR #40861:
URL: https://github.com/apache/beam/pull/40861#discussion_r4397239948
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java:
##########
@@ -88,6 +92,22 @@ private IcebergUtils() {}
.put(EnumerationType.IDENTIFIER, Types.StringType.get())
.build();
+ private static final DateTimeFormatter TIMESTAMP_SPACE_FORMATTER =
+ new DateTimeFormatterBuilder()
+ .parseCaseInsensitive()
+ .append(ISO_LOCAL_DATE)
+ .appendLiteral(' ')
+ .append(ISO_LOCAL_TIME)
+ .toFormatter();
Review Comment:
Fixed in f7586e9. Both formatters now use ResolverStyle.STRICT with
IsoChronology.INSTANCE, so invalid dates are rejected the same way as on the T
path. Added testTimestampStringWithInvalidDate for both separators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
