Rishavbhattarai commented on issue #18692: URL: https://github.com/apache/beam/issues/18692#issuecomment-6462696827
.take-issue I'd like to take this one too (I'm doing #18691 in #40865). `DatastoreV1Test` can't move to `TestPipeline`: the fns under test hold Mockito mocks from `mockDatastoreFactory`, which can't be serialized, and the tests check those mocks after the bundle runs. That's why every call sets `DO_NOT_CLONE` today. My plan is a small `processBundle(fn, inputs)` helper in the test that runs the fn in-process through `DoFnRunners.simpleRunner`, and to swap the 10 `DoFnTester` call sites over to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
