shunping commented on PR #40879: URL: https://github.com/apache/beam/pull/40879#issuecomment-6529424363
> The comments in the proto seems useful. However, we should not revive the idea of triggers "finishing", and we should remove it from any SDK it has snuck into. It is not very useful for saying "good enough, throw away the rest of the data" because triggers are not expressive enough for that - instead, use state/timers or some other filter. It is very easy to accidentally make a trigger that drops data that you don't realize. This happened a lot in the early days, hence I made the breaking change to remove it. Thanks! I reworded the header comment and stated that the root trigger should never finish. I kept the explanation on what "finish" is mainly for subtriggers, because I find it is easier to explain composite triggers (e.g `AfterEach`, `Repeat`, etc.) this way. Let me know if you have other thoughts. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
