github-actions[bot] commented on code in PR #41031:
URL: https://github.com/apache/beam/pull/41031#discussion_r4489065332


##########
buildSrc/build.gradle.kts:
##########
@@ -32,7 +32,7 @@ val useMirror = isCi && !mavenCentralMirrorUrl.isNullOrBlank()
 plugins {
   `java-gradle-plugin`
   groovy
-  id("com.diffplug.spotless") version "7.2.1"
+  id("com.diffplug.spotless") version "8.11.0"

Review Comment:
   **🔴 Critical**: Spotless `8.0.0`+ requires Java 17+ (class file version 
61.0) to run. Applying `8.11.0` in `buildSrc` causes all Gradle invocations 
running on JDK 11 (such as the `Java Unit Tests` and `Java Wordcount Direct 
Runner` jobs in `.github/workflows/java_tests.yml`) to fail during `buildSrc` 
configuration. Please keep Spotless on `7.2.1` (the last 7.x release supporting 
Java 11) until Gradle execution in CI requires Java 17+, and note that line 67 
(`runtimeOnly("com.diffplug.spotless:spotless-plugin-gradle:7.2.1")`) would 
also need to be updated in tandem when upgrading.
   
   ```suggestion
     id("com.diffplug.spotless") version "7.2.1" // Do not bump to 8.x which 
requires Java 17
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to