damccorm commented on code in PR #41155:
URL: https://github.com/apache/beam/pull/41155#discussion_r4526236176
##########
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java:
##########
@@ -278,6 +278,9 @@ private static State waitUntilFinish(PipelineResult result,
AtomicBoolean cancel
State state = result.waitUntilFinish();
checkNotCancelled(cancelFlag);
return state;
+ } catch (RuntimeException e) {
+ checkNotCancelled(cancelFlag);
Review Comment:
Done — applied the same `try / catch (RuntimeException e)` guard in
`limitRun` and attached `e` as a suppressed exception on the
`CancellationException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
