Abhi2939 commented on PR #41154: URL: https://github.com/apache/beam/pull/41154#issuecomment-6777293573
Thanks for the review, @shunping! I've pushed an update that addresses all three points: - **Docstring:** removed the addition. I moved the 16-17 digit caveat into the inline comment above `kwargs.setdefault(...)`. - **Truncation case:** the test now includes `0.1234567890123456`, which needs 16 decimal places and is rounded to 15 by default, with a comment explaining why. - **Consolidation:** merged the two tests into a single `test_float_precision` that checks the default and the explicit `double_precision=10` override. I also confirmed the new test fails without the fix. Could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
