09Catho commented on PR #41084: URL: https://github.com/apache/beam/pull/41084#issuecomment-6786299770
Pushed 86d7628. The review bot's point holds: with the KeyError fixed, a committed-only metric comes back with `attempted=None`, and `query()` only looks at `attempted` when sorting results by type, so the metric was dropped. The type checks now fall back to `committed` when `attempted` is None, with a test for it. This push also fixes the PythonFormatter failure (yapf 0.43.0 reflow of the new test). PythonDocs finished its Gradle build (`BUILD SUCCESSFUL in 28m 33s`) and was then cancelled at the 30 minute job limit, so I don't think it's related to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
