sohailshk opened a new pull request, #41195: URL: https://github.com/apache/beam/pull/41195
Fixes #41193 `MonotonicWatermarkEstimator.default_provider()` starts the estimator with a `None` watermark. Once a timestamp was observed, `current_watermark()` compared it with that `None` and raised `TypeError`. It now takes the observed timestamp as the watermark when there is none yet; the existing monotonic behaviour is unchanged. `test_observe_timestamp_without_initial_state` starts from `None`, observes 15 and then 10, and checks that the watermark is 15 both times. It fails on master and passes with the fix; `watermark_estimators_test.py` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
