ayush-builds-stuff opened a new pull request, #41203:
URL: https://github.com/apache/beam/pull/41203
## Summary
The dev build environment image is built `FROM ubuntu:24.04`, which is
multi-arch, so on
arm64 hosts the image is arm64 — but the Go toolchain installed into it was
always
`linux-amd64`. The result is an image carrying a toolchain that does not
match the image it
lives in:
- With binfmt emulation available (Docker Desktop + Rosetta), `go` silently
runs emulated:
`go env GOARCH` reports `amd64` inside an `arm64` container, and every Go
step is slow.
- Without emulation (arm64 Linux hosts, minimal Docker setups), it fails
outright with
`/lib64/ld-linux-x86-64.so.2: cannot open shared object file`, as reported
in #20983.
This derives the Go download from the architecture of the image being built,
and asserts
`go version` in the same layer so a future arch mismatch fails the build
instead of
producing a silently broken image.
fixes #20983
## Implementation
- `arch` comes from BuildKit's `TARGETARCH` (values `amd64`/`arm64`, the
same naming Go uses),
with `dpkg --print-architecture` as the fallback for legacy-builder builds
where
`TARGETARCH` is unset.
- Download host switched from `golang.org/dl` (which 301s to `go.dev`) to
`go.dev/dl`, and the
tarball is removed from the layer after extraction.
- Grepped `dev-support/`: this was the only hardcoded `amd64` left.
## Testing
Both platforms were built end-to-end from this Dockerfile on an M-series
Mac, and both
produce a toolchain that matches the image:
$ docker build --platform linux/arm64 -f dev-support/docker/Dockerfile
-t beam-build:arm64 dev-support/docker
#16 go version go1.26.2 linux/arm64 # PASS
$ docker run --rm beam-build:arm64 sh -c 'dpkg --print-architecture; go
version; go env GOARCH'
arm64
go version go1.26.2 linux/arm64
arm64
$ docker build --platform linux/amd64 -f dev-support/docker/Dockerfile
-t beam-build:amd64 dev-support/docker
#16 go version go1.26.2 linux/amd64 # PASS
(emulated, no amd64 hardware available)
$ docker run --rm --platform linux/amd64 beam-build:amd64 sh -c 'dpkg
--print-architecture; go version;go env GOARCH'
amd64
go version go1.26.2 linux/amd64
amd64
In both images a trivial program compiles and runs with the matching
architecture
(`go build && ./prog` → `ok arm64` / `ok amd64`).
Architecture selection was also probed directly on both platforms:
--platform linux/arm64 → TARGETARCH=arm64 dpkg=arm64
--platform linux/amd64 → TARGETARCH=amd64 dpkg=amd64
Not exercised: the `dpkg --print-architecture` fallback used when
`TARGETARCH` is unset
(legacy builder, `DOCKER_BUILDKIT=0`). BuildKit is the default, and the
fallback resolves to
the same value as `TARGETARCH` on both architectures above.
Also note the `LegacyKeyValueFormat` build warnings are pre-existing, on
untouched `ENV` lines.
No `CHANGES.md` entry: internal build tooling, no user-facing behavior
change.
## AI disclosure
Investigated, implemented and tested with an AI coding agent (Pi-Bolt). The
account owner
reviewed the change, owns the content, and is responsible for it.
Credit to @rokadepiyush49-rgb for the diagnosis in #20983.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
