damccorm commented on code in PR #41160:
URL: https://github.com/apache/beam/pull/41160#discussion_r4539187066
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -736,17 +736,18 @@ def __init__(self, placeholder):
if default_arg_values:
for a, d in zip(arg_names[-len(default_arg_values):], default_arg_values):
if core.DoFn.ElementParam == d:
- args_with_placeholders.append(ArgPlaceholder(d))
+ args_with_placeholders.append(ArgPlaceholder(core.DoFn.ElementParam))
Review Comment:
For context - all of these replacements do not have perf impact by
themselves. They happen before job submission (before pickling).
They just enable the `is` checks below to work since now `p` will be
referring to the original singleton instead of a _DoFnParam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
