damccorm commented on code in PR #41209:
URL: https://github.com/apache/beam/pull/41209#discussion_r4539513577
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1833,14 +1845,6 @@ def _maybe_propagate_windowing_info(self,
windowed_input_element, result):
else:
return windowed_input_element.with_value(result)
- def _handle_tagged_output(self, result):
Review Comment:
I split this out into its own pr because there are fairly clear tradeoffs.
We're trading abstraction/cleaner code for small perf improvements on the hot
path. I still think this is worth it, but wanted to isolate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
