damccorm commented on code in PR #41235:
URL: https://github.com/apache/beam/pull/41235#discussion_r4559644594


##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/catalog/BigQueryMetastoreCatalogIT.java:
##########
@@ -89,6 +91,26 @@ public Map<String, Object> managedIcebergConfig(String 
tableId) {
         .build();
   }
 
+  @Override
+  public void catalogCleanup(List<Namespace> namespaces) throws IOException {

Review Comment:
   Instead of overriding, should we make this the default behavior in the 
superclass?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to