damccorm commented on code in PR #41013:
URL: https://github.com/apache/beam/pull/41013#discussion_r4559480484
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java:
##########
@@ -311,12 +439,42 @@ JmsCheckpointMark newCheckpoint(
return checkpointMark;
}
+ /**
+ * A checkpoint without messages. Finalizing it still acknowledges the
earlier checkpoints of
+ * this reader.
+ */
JmsCheckpointMark emptyCheckpoint() {
- return new JmsCheckpointMark(oldestMessageTimestamp, null, null, null,
null);
+ return new JmsCheckpointMark(
+ pendingCheckpoints,
+ pendingCheckpoints.nextSequence(),
+ oldestMessageTimestamp,
+ null,
+ 0,
+ null,
+ null,
+ null);
}
boolean isEmpty() {
return messages.isEmpty();
Review Comment:
I think we can ignore this, since impact is minimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
