damccorm commented on code in PR #41207:
URL: https://github.com/apache/beam/pull/41207#discussion_r4564483838
##########
sdks/python/apache_beam/runners/interactive/interactive_beam_test.py:
##########
@@ -909,6 +909,7 @@ def test_async_computation_result_cancel(self):
# This part is hard to test without deeper runner integration
with self.assertRaises(TimeoutError):
async_result.result(timeout=1) # It should not complete successfully
+ async_result.wait_for_completion(timeout=30)
Review Comment:
Instead of waiting for completion, is there a way to actually force cancel
the job? Then we could reraise the time.sleep to 100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
