lukecwik commented on pull request #13101: URL: https://github.com/apache/beam/pull/13101#issuecomment-708069800
@iemejia @echauchot I added some very rudimentary support for watermark holds influencing the output watermark. Most but not all of the existing validatesRunnerStreaming tests work but a few get stuck with the watermark not advancing to infinity. I also tried running the ImpulseTest from the `ValidatesRunner` junit category and it fails because it thinks there aren't any output operators registered: ``` java.lang.IllegalArgumentException: requirement failed: No output operations registered, so nothing to execute ``` I would have suspected that the [EvaluationContext#computeOutputs](https://github.com/apache/beam/blob/42aff4d55954f63405a67956e0c6884e2347d772/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/EvaluationContext.java#L222) would have forced the leaves to be computed. repro by checking this PR out and running: ``` ./gradlew :runners:spark:validatesRunnerStreaming2 --tests "org.apache.beam.sdk.transforms.ImpulseTest" ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
