iemejia edited a comment on pull request #12583: URL: https://github.com/apache/beam/pull/12583#issuecomment-710188499
Oh maybe I was not clear, I did not expect anything fancier, only two things: (1) that we create a specific test for the duplicateKey case and not do it in the generic write test (you can basically reuse the code but in a different method not to affect the normal path, and (2) that you pass duplicate keys as part of the write to see if deduplication is working. That should be enough. The sole doubt I have is how can we guarantee that the keys are part of the same batch. I assume that `DirectRunner` will put them by default in the same bundle. I suppose we can debug to verify this. In the past we used a class called `DoFnTester` for cases like this but I don't think we have an alternative way to guarantee that two elements end up in the same bundle. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
