lostluck commented on a change in pull request #13115:
URL: https://github.com/apache/beam/pull/13115#discussion_r508018260
##########
File path: model/pipeline/src/main/proto/standard_window_fns.proto
##########
@@ -25,7 +25,7 @@ syntax = "proto3";
package org.apache.beam.model.pipeline.v1;
-option go_package = "pipeline_v1";
+option go_package =
"github.com/apache/beam/sdks/go/pkg/beam/model/pipeline_v1;pipeline_v1";
Review comment:
If you look bit further you can see the actual protocol buffer field for
go_package (cus apparently Protos are self describing on multiple levels).
Part of the reason this change is so big is because in the last year the
implementation of Go protocol buffers changed dramatically, and apparently
they're moving to recommending the full package path for go_packages now. This
is overall good since it means it will be able to work with Go Modules
eventually. Who knows, Maybe it eventually saves us from needing to regenerate
them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
