iemejia commented on a change in pull request #13287:
URL: https://github.com/apache/beam/pull/13287#discussion_r524129225
##########
File path: sdks/java/io/hadoop-common/build.gradle
##########
@@ -16,17 +16,21 @@
* limitations under the License.
*/
+import java.util.stream.Collectors
+
plugins { id 'org.apache.beam.module' }
applyJavaNature(automaticModuleName: 'org.apache.beam.sdk.io.hadoop.common')
description = "Apache Beam :: SDKs :: Java :: IO :: Hadoop Common"
ext.summary = "Library to add shared Hadoop classes among Beam IOs."
-configurations {
- hadoopVersion285
-}
+def hadoopVersions = [
+ "285": "2.8.5",
+ "292": "2.9.2",
+ "2101": "2.10.1",
Review comment:
I also was thinking if we could define this globally so we don't have
this copy pasted everywhere as well as the hadoopVersions chunk, but my gradle
fu is not so high to purpose a way to do it. I mean also if there is not some
way to create something like
https://github.com/apache/beam/blob/fb23d3f37079c5afbb55c72ec4a7c321050c674d/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L728
that can be configurable only at each module level, to have less repeated code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
