aaltay commented on a change in pull request #13292:
URL: https://github.com/apache/beam/pull/13292#discussion_r526324457



##########
File path: sdks/python/apache_beam/transforms/util.py
##########
@@ -780,6 +783,48 @@ def expand(self, pcoll):
             self.max_buffering_duration_secs,
             self.clock))
 
+  @typehints.with_input_types(Tuple[K, V])
+  @typehints.with_output_types(Tuple[K, Iterable[V]])
+  class WithShardedKey(PTransform):
+    """A GroupIntoBatches transform that outputs batched elements associated
+    with sharded input keys.
+
+    The sharding is determined by the runner to balance the load during the

Review comment:
       For my understanding. So, windmill understands the coding for shardedkey 
and the implementation here is the default implementation for cases where 
runner does not do this overriding?
   
   If this is correct, could you update the comment to explain this a bit more 
to the reader?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to