TheNeuralBit commented on pull request #13401:
URL: https://github.com/apache/beam/pull/13401#issuecomment-732532147


   > as it seems this hasn't exposed bugs outside of verifying preservation of 
Singleton, right?
   
   There was one other case. The `map_index` expression used when grouping by a 
callable: 
https://github.com/apache/beam/blob/ae1df915a5b487ffea5e53aaa615d00739ad989d/sdks/python/apache_beam/dataframe/frames.py#L137-L141
   
   It was flagged for not preserving Index partitioning. It should specify 
`preserves=Nothing` since the mapper could produce overlapping partitions


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to