aromanenko-dev commented on a change in pull request #13411:
URL: https://github.com/apache/beam/pull/13411#discussion_r533594798
##########
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/options/AwsOptions.java
##########
@@ -38,9 +38,9 @@
/** AWS region used by the AWS client. */
@Description("AWS region used by the AWS client")
@Validation.Required
- String getRegion();
Review comment:
Yes, makes sense. But don't you think we have to change it to avoid
naming conflicts? Also, looking into the code, I don't see if these options
have been even used before for AWS v2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
