boyuanzz commented on a change in pull request #13431:
URL: https://github.com/apache/beam/pull/13431#discussion_r533751926
##########
File path: sdks/python/apache_beam/runners/common.py
##########
@@ -218,10 +218,11 @@ def __init__(self, obj_to_invoke, method_name):
elif core.DoFn.KeyParam == v:
self.key_arg_name = kw
elif isinstance(v, core.DoFn.RestrictionParam):
- self.restriction_provider = v.restriction_provider
+ self.restriction_provider = v.restriction_provider or obj_to_invoke
Review comment:
I understand. The case I'm wondering is like:
```python
class MySDF(beam.DoFn, TypeARestrictionTracker):
def
process(restriction_tracker=RestrictionParam(TypeBRestrictionTracker()))
```
In this case, the sdk will pick up `TypeBRestrictionTracker` implementation.
Is it ideal? I thought we want to pick up `TypeARestrictionTracker` in this
case or just say the DoFn is not valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
