scwhittle commented on pull request #13318: URL: https://github.com/apache/beam/pull/13318#issuecomment-737455805
Fixed On Wed, Dec 2, 2020 at 8:38 PM reuvenlax <notificati...@github.com> wrote: > *@reuvenlax* commented on this pull request. > ------------------------------ > > In > sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/queries/Query5.java > <https://github.com/apache/beam/pull/13318#discussion_r534432052>: > > > @@ -53,6 +63,79 @@ > public class Query5 extends NexmarkQueryTransform<AuctionCount> { > private final NexmarkConfiguration configuration; > > + public static class TopCombineFn > + extends AccumulatingCombineFn<KV<Long, Long>, Accum, KV<Long, List<Long>>> { > + @Override > + public Accum createAccumulator() { > + return new Accum(); > + } > + > + @Override > + public Coder<Accum> getAccumulatorCoder( > + @NonNull CoderRegistry registry, @NonNull Coder<KV<Long, Long>> inputCoder) { > + JavaFieldSchema provider = new JavaFieldSchema(); > + TypeDescriptor<Accum> typeDescriptor = new TypeDescriptor<Accum>() {}; > + provider.schemaFor(typeDescriptor); > > why do you call schemaFor twice? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/13318#pullrequestreview-543175578>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABBZZTE7S3TAUSA4OXULTVTSS2JUXANCNFSM4TTKVY2Q> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
