bntnam commented on a change in pull request #13439: URL: https://github.com/apache/beam/pull/13439#discussion_r537215093
########## File path: website/www/site/static/js/hero/hero-desktop.js ########## @@ -0,0 +1,19 @@ +// Licensed under the Apache License, Version 2.0 (the 'License'); you may not +// use this file except in compliance with the License. You may obtain a copy of +// the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT +// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +// License for the specific language governing permissions and limitations under +// the License. + +var animation = bodymovin.loadAnimation({ + container: document.getElementById("hero-desktop"), + renderer: "svg", + loop: false, + autoplay: true, + path: "/js/hero/hero-desktop.json", Review comment: Hmm, thanks for your suggestion about `animationData`. I agree that maybe that has its own drawback. However, this approach solves 2 questions (license headers of json files & staging deployment). Then, I'd go for it. 😄 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
