rHermes edited a comment on pull request #13435:
URL: https://github.com/apache/beam/pull/13435#issuecomment-746806274


   > Thanks for your work @rHermes !
   > Only some minor fixes and an important comment.
   > Nexmark execution times are similar to CI. So LGTM
   > On piece of advice, it is your second cleaning PR on nexmark. Next time, 
could you please consider submitting cleaning PRs all in a single PR with 
separate commits with explicit messages? thanks
   
   I thought it was better practice to create separate PRs, but it's easier for 
me to just combine them, so I'll do that next time :)
   
   Sorry for not answering sooner @echauchot life caught up to me :sweat_smile: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to